Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(language-server): Use vitest intead of mocha #1727

Merged
merged 3 commits into from
May 15, 2024
Merged

test(language-server): Use vitest intead of mocha #1727

merged 3 commits into from
May 15, 2024

Conversation

SevInf
Copy link
Member

@SevInf SevInf commented May 15, 2024

Only language-server package for now

Copy link

github-actions bot commented May 15, 2024

🤖 Pull request artifacts

empty string

file commit
prisma.vsix 614dbde

github-actions bot added a commit that referenced this pull request May 15, 2024
Copy link

github-actions bot added a commit that referenced this pull request May 15, 2024
github-actions bot added a commit that referenced this pull request May 15, 2024
@Druue Druue requested review from Druue and Jolg42 May 15, 2024 11:54
@Jolg42
Copy link
Contributor

Jolg42 commented May 15, 2024

What do you think about this warning?

vitest
The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
https://github.com/prisma/language-tools/actions/runs/9094944497/job/24997090735?pr=1727#step:6:15

The CJS build of Vite's Node API is deprecated and will be removed in Vite 6. See the GitHub discussion for more context. You should update your files or frameworks to import the ESM build of Vite instead.

@Jolg42 Jolg42 added this to the 5.15.0 milestone May 15, 2024
@Druue
Copy link
Contributor

Druue commented May 15, 2024

What do you think about this warning?

vitest
The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
https://github.com/prisma/language-tools/actions/runs/9094944497/job/24997090735?pr=1727#step:6:15

The CJS build of Vite's Node API is deprecated and will be removed in Vite 6. See the GitHub discussion for more context. You should update your files or frameworks to import the ESM build of Vite instead.

Seems like a sign to move over to esbuild (which would also let us migrate to pnpm) but we'll have to stick to mocha/cjs for e2e tests
microsoft/vscode#130367

@SevInf SevInf force-pushed the multifile-support branch 2 times, most recently from 99312ec to 8c51c69 Compare May 15, 2024 12:47
Base automatically changed from multifile-support to main May 15, 2024 12:50
@Jolg42
Copy link
Contributor

Jolg42 commented May 15, 2024

@Druue Nice find, I'm ok if we get stuck on vitest v5 personally, it's better than Mocha.

@SevInf
Copy link
Member Author

SevInf commented May 15, 2024

I think the warning comes from vite.config.ts and we can pretty much solve it by using .mts extension isntead.

github-actions bot added a commit that referenced this pull request May 15, 2024
@SevInf SevInf marked this pull request as ready for review May 15, 2024 13:10
github-actions bot added a commit that referenced this pull request May 15, 2024
@SevInf
Copy link
Member Author

SevInf commented May 15, 2024

Update: warning is gone

Copy link
Contributor

@Druue Druue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SevInf SevInf merged commit c45b1a5 into main May 15, 2024
7 checks passed
@SevInf SevInf deleted the feat/vitest branch May 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants