Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dmmf): add full index information #4949

Merged
merged 10 commits into from
Jul 11, 2024
Merged

feat(dmmf): add full index information #4949

merged 10 commits into from
Jul 11, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jul 10, 2024 •
edited
Loading

Add complete index information to the datamodel section of the DMMF.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4949 will not alter performance

Comparing integration/dmmf-indexes (d964e5c) with main (5954db1)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.044MiB 2.044MiB 0.000B
Postgres (gzip) 814.637KiB 814.779KiB -145.000B
Mysql 2.013MiB 2.013MiB 252.000B
Mysql (gzip) 801.103KiB 801.058KiB 46.000B
Sqlite 1.915MiB 1.915MiB 248.000B
Sqlite (gzip) 763.664KiB 763.621KiB 44.000B

@aqrln aqrln changed the title feat(dmmf): add index information feat(dmmf): add full index information Jul 10, 2024
@aqrln aqrln added this to the 5.17.0 milestone Jul 10, 2024
@aqrln aqrln marked this pull request as ready for review July 10, 2024 21:47
@aqrln aqrln requested a review from a team as a code owner July 10, 2024 21:47
@aqrln aqrln requested review from jkomyno and removed request for a team July 10, 2024 21:48
Druue
Druue approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Druue Druue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aqrln aqrln mentioned this pull request Jul 11, 2024
Merged
@aqrln aqrln merged commit 9618390 into main Jul 11, 2024
212 checks passed
@aqrln aqrln deleted the integration/dmmf-indexes branch July 11, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf left review comments

@Druue Druue Druue approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aqrln @SevInf @Druue