Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore(deps): bump openssl from 0.10.60 to 0.10.66" #4995

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Revert "chore(deps): bump openssl from 0.10.60 to 0.10.66" #4995

merged 2 commits into from
Sep 2, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Sep 2, 2024

Reverts #4965 to fix the prisma/prisma#25101 regression, according to prisma/prisma#25101 (comment) and prisma/prisma#25101 (comment).

TODO, post patch release:

  • write an ecosystem tests that reflects that user's scenario, with Ubuntu 22.04 defaulting on OpenSSL 1.1.x.

@jkomyno jkomyno added this to the 5.19.1 milestone Sep 2, 2024
@jkomyno jkomyno self-assigned this Sep 2, 2024
@jkomyno jkomyno requested a review from a team as a code owner September 2, 2024 09:59
@jkomyno jkomyno requested review from laplab and aqrln and removed request for a team and laplab September 2, 2024 09:59
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 2, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4995 will not alter performance

Comparing revert-4965-dependabot/cargo/openssl-0.10.66 (1c3539e) with main (8225295)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.063MiB 2.063MiB 0.000B
Postgres (gzip) 823.718KiB 823.718KiB 0.000B
Mysql 2.033MiB 2.033MiB 0.000B
Mysql (gzip) 811.295KiB 811.297KiB -2.000B
Sqlite 1.924MiB 1.924MiB 0.000B
Sqlite (gzip) 768.301KiB 768.302KiB -1.000B

@jkomyno
Copy link
Contributor Author

jkomyno commented Sep 2, 2024

Side note: I've pushed 1c3539e to avoid

line 5: syntax error near unexpected token `('
errors in https://github.com/prisma/prisma-engines/actions/runs/10664988277/job/29557431036/?pr\=4995\#step:4:13.

@jkomyno jkomyno merged commit f2561ec into main Sep 2, 2024
368 checks passed
@jkomyno jkomyno deleted the revert-4965-dependabot/cargo/openssl-0.10.66 branch September 2, 2024 10:42
jkomyno added a commit that referenced this pull request Sep 2, 2024
@jkomyno
Revert "chore(deps): bump openssl from 0.10.60 to 0.10.66" (#4995)
69d742e 
* Revert "chore(deps): bump openssl from 0.10.60 to 0.10.66 (#4965)"

This reverts commit ae18f91.

* chore(ci): stop showing commit message to avoid bad substitutions like https://github.com/prisma/prisma-engines/actions/runs/10664988277/job/29557431036\?pr\=4995\#step:4:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

Assignees

@jkomyno jkomyno

Labels
None yet
Projects
None yet
Milestone
5.19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jkomyno @aqrln