Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix workflows used to release and publish npm package #45

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jul 21, 2023

Configuration updates:

  • Add the missing workspace directive in the "release" workflow. The version in the root package.json file was previously updated instead of the versions in the addons workspace.
  • "npm publish" workflow: pass cli option instead of using .npmrc file (not sure it was used, command is now more explicit).
  • Explicitly mark the addons workspace as public in package.json. This ensures that the value is not inherited from the root package.json.

Fix the versions in package.json files that have been incorrectly updated in v0.1.0:

  • Revert version added to the root package.json. This is not the package that should have been published.
  • Restore the right version in the "addons" workspace.

Add the missing workspace directive in the "release" workflow.
Revert version added to the root package.json. This is not the package that should have been
published.
Restore the right version in the "addons" workspace.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jul 21, 2023
@tbouffard tbouffard changed the title chore: fix workflow used to release and publish npm package chore: fix workflows used to release and publish npm package Jul 21, 2023
@tbouffard tbouffard merged commit 4b29e55 into main Jul 21, 2023
1 check passed
@tbouffard tbouffard deleted the chore/fix_npm_publish branch July 21, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant