Updated spec with reviews by @Herringway #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected some keys in example displays - Corrected a couple of missing ':' prefix in an example displays - Deduplicated `RPL_METADATASUBS` in the numerics table - Replaced RPL_ placeholders with their actual numeric value in examples Only thing I didn't touch is [this one](ircv3#501 (comment)) purely because the spec already mentions that `metadata-2` requires `batch` to work, so shouldn't be a problem =] Thank you Herringway for taking the time to point these out!
|
sorry, I wasn't as clear on that one as I should have been. I meant that RPL_METADATASUBS replies aren't in a batch or have an end-of-list numeric, so they're a little tricky to deal with. Without those, it's hard to know when you've got a complete response |
|
@Herringway good point. I wonder if we should add another batch type for this. (I feel making a labeled-response batch mandatory for this particular case would be somewhat abusive) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPL_METADATASUBSin the numerics tableOnly thing I didn't touch is this one purely because the spec already mentions that
metadata-2requiresbatchto work, so shouldn't be a problem =]Thank you @Herringway for taking the time to point these out!