Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Implement redesign of signature icons and tooltips #383

Closed
andaaron opened this issue Sep 7, 2023 · 0 comments · Fixed by #427
Closed

[Feat] Implement redesign of signature icons and tooltips #383

andaaron opened this issue Sep 7, 2023 · 0 comments · Fixed by #427
Assignees
Labels
ui ZOT web-based UI related tasks
Milestone

Comments

@andaaron
Copy link
Contributor

andaaron commented Sep 7, 2023

See attachments for current implementation.

Verified signature:
Image

Unverified signature:
Image

These 2 cases are not enough anymore. We need a redesign. On August 30th we decided to make the following changes:

  1. Instead of a single shield icon for any signature we would show 2 separate icons: 1 for cosign and 1 for notation.
  • The icons themselves should be coming from the open source resources of the cosign and notation project.
  • The icon coloring would reflect the following states:
    • Red if there is no signature of the given type (cosign/notation) applicable to the specific image/tag.
    • Amber if there is at least one signature of the given type (cosign/notation) applicable to the specific image/tag, but all of these signatures have "trusted" set to "false"
    • Green if there is at least one signature of the given type (cosign/notation) applicable to the specific image/tag, and at least one of these signatures has "trusted" set to "true"
  1. Update the tooltip to remove the "verified", "trusted", "type" information, as it would be already reflected in the icon coloring, no need to include it in the tooltip. The tooltip would continue to include the "Author: [...]" information, as it is presented in current implementation.
@andaaron andaaron added the ui ZOT web-based UI related tasks label Sep 7, 2023
@andaaron andaaron changed the title [Redesign] Signature icons and tooltips are inconsistent [Feat] Implement redesign of signature icons and tooltips Sep 7, 2023
@andaaron andaaron added this to the v2.0.0 milestone Sep 13, 2023
@andaaron andaaron linked a pull request Mar 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui ZOT web-based UI related tasks
Projects
None yet
3 participants