patch: signature display redesign #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulkele
force-pushed
the
patch/signature-redesign
branch
from
20596fd
to
6b8be1f
Compare
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 86.73% 86.26% -0.48%
==========================================
Files 53 53
Lines 1553 1587 +34
Branches 416 426 +10
==========================================
+ Hits 1347 1369 +22
- Misses 193 206 +13
+ Partials 13 12 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raulkele
force-pushed
the
patch/signature-redesign
branch
from
6b8be1f
to
078d699
Compare
andaaron
approved these changes
Oct 16, 2023
Signed-off-by: Raul-Cristian Kele <raulkeleblk@gmail.com>
raulkele
force-pushed
the
patch/signature-redesign
branch
from
078d699
to
494efdc
Compare
Andreea-Lupu
approved these changes
Nov 2, 2023
|
Picked up and superseded by #427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
Closes #383
What does this PR do / Why do we need it:
Implements changes to signature display. Redesign signature related component logic
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.