Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update auth flow and add third party auth #360

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

raulkele
Copy link
Collaborator

What type of PR is this?
feature

Closes #355
Closes #351
Closes #359
Which issue does this PR fix:

What does this PR do / Why do we need it:
Implements the openid authentication flow (needs project-zot/zot#1381 to be merged)
Update signin page ui design

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@raulkele raulkele marked this pull request as draft June 28, 2023 17:15
@raulkele raulkele force-pushed the feat/auth-config-integration branch 2 times, most recently from 08335a8 to e68181b Compare July 5, 2023 15:01
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #360 (2e880cd) into main (a552487) will decrease coverage by 2.83%.
The diff coverage is 56.91%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   90.29%   87.46%   -2.83%     
==========================================
  Files          50       52       +2     
  Lines        1422     1516      +94     
  Branches      357      381      +24     
==========================================
+ Hits         1284     1326      +42     
- Misses        129      180      +51     
- Partials        9       10       +1     
Impacted Files Coverage Δ
src/components/Header/UserAccountMenu.jsx 0.00% <0.00%> (ø)
src/components/Login/TermsOfService.jsx 0.00% <ø> (-100.00%) ⬇️
src/components/Login/ThirdPartyLoginComponents.jsx 5.88% <5.88%> (ø)
src/components/Header/Header.jsx 70.00% <50.00%> (-5.00%) ⬇️
src/utilities/authUtilities.js 51.85% <50.00%> (-48.15%) ⬇️
src/components/Login/SignIn.jsx 87.06% <77.55%> (-9.23%) ⬇️
src/App.js 100.00% <100.00%> (ø)
src/api.js 70.00% <100.00%> (+9.47%) ⬆️
src/components/Login/SignInPresentation.jsx 100.00% <100.00%> (ø)
src/pages/LoginPage.jsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raulkele raulkele force-pushed the feat/auth-config-integration branch 3 times, most recently from a570e8c to 08510be Compare July 15, 2023 06:46
Signed-off-by: Raul-Cristian Kele <raulkeleblk@gmail.com>
@raulkele raulkele force-pushed the feat/auth-config-integration branch from 08510be to 2e880cd Compare July 16, 2023 17:25
@raulkele raulkele marked this pull request as ready for review July 17, 2023 13:58
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 8086f68 into project-zot:main Jul 17, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants