feat: Update signature integration to display extra info #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 87.50% 86.14% -1.36%
==========================================
Files 52 53 +1
Lines 1529 1545 +16
Branches 399 408 +9
==========================================
- Hits 1338 1331 -7
- Misses 179 201 +22
- Partials 12 13 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
How will the UI look like with this change? |
raulkele
force-pushed
the
feat/update-signature-data-usage
branch
from
4664f11
to
f3925b5
Compare
andaaron
approved these changes
Aug 28, 2023
Signed-off-by: Raul-Cristian Kele <raulkeleblk@gmail.com>
raulkele
force-pushed
the
feat/update-signature-data-usage
branch
from
f3925b5
to
1e81837
Compare
andaaron
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
Closes #374
What does this PR do / Why do we need it:
Display advanced signature information in zui. Design still WIP
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.