feat: added button to delete tag #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
raulkele and
ameliamariabreda
eusebiu-constantin-petu-dbk
force-pushed
the
delete_tag
branch
2 times, most recently
from
b84f125
to
3a1ea9c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 87.26% 87.49% +0.22%
==========================================
Files 53 55 +2
Lines 1594 1623 +29
Branches 436 433 -3
==========================================
+ Hits 1391 1420 +29
- Misses 190 192 +2
+ Partials 13 11 -2 ☔ View full report in Codecov by Sentry. |
eusebiu-constantin-petu-dbk
force-pushed
the
delete_tag
branch
10 times, most recently
from
ffd49a4
to
dd1a24c
Compare
raulkele
requested changes
Dec 14, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
delete_tag
branch
from
dd1a24c
to
68f6817
Compare
|
@raulkele fixed all comments, thank you! |
eusebiu-constantin-petu-dbk
force-pushed
the
delete_tag
branch
from
68f6817
to
8b25eeb
Compare
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
delete_tag
branch
from
8b25eeb
to
07dd11c
Compare
andaaron
approved these changes
Dec 14, 2023
This was referenced Dec 17, 2023
|
Thanks @eviishondell for PR #391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.