Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting blacklight-version #3022

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable setting blacklight-version #3022

wants to merge 5 commits into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jun 21, 2024

We do this in the github config, but we never use that value

Fixes #3025

@jcoyne jcoyne force-pushed the blacklight-latest branch 2 times, most recently from 6da08a5 to 0336789 Compare June 21, 2024 14:13
@jcoyne jcoyne changed the title Enable setting blacklight-version to 'latest' Enable setting blacklight-version Jun 21, 2024
@jcoyne
Copy link
Member Author

jcoyne commented Jun 21, 2024

Failures are possibly due to one of these problems:

    generate  spotlight:install
       rails  generate spotlight:install -f --mailer_default_url_host=localhost:3000
warning: parser/current is loading parser/ruby32, which recognizes 3.2.4-compliant syntax, but you are running 3.2.3.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
The file /Users/jcoyne85/workspace/projectblacklight/spotlight/.internal_test_app/app/assets/javascripts/application.js does not appear to exist
      append  app/assets/config/manifest.js
       force  app/controllers/catalog_controller.rb
    rakefile  spotlight_test.rake
      create  config/initializers/carrierwave.rb
      create  app/assets/images/spotlight/themes/default_preview.png
      create  app/assets/images/spotlight/themes/modern_preview.png
      create  app/assets/stylesheets/application_modern.css
      append  config/initializers/assets.rb
The file /Users/jcoyne85/workspace/projectblacklight/spotlight/.internal_test_app/config/initializers/spotlight_initializer.rb does not appear to exist

We do this in the github config, but we never use that value
This is the default Blacklight 8 path. Javascripts now go in app/javascripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacklight 8 builds are not actually using blacklight 8.
1 participant