Replacing header nav partial with header component #3136
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudajkhan
force-pushed
the
bl8headernav
branch
from
2c8a29c
to
1e4545c
Compare
hudajkhan
force-pushed
the
bl8headernav
branch
from
1e4545c
to
ef60301
Compare
|
I wonder if there's a backwards-compatible way to introduce this change (that won't require downstream applications to add the Maybe we could keep the header_navbar partial? |
|
@cbeer I brought the partial back and its associated test and set up with a deprecation warning. |
jcoyne
requested changes
Sep 21, 2024
| @@ -0,0 +1,13 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| describe 'shared/_header_navbar', type: :view do | |||
There was a problem hiding this comment.
Suggested change
| describe 'shared/_header_navbar', type: :view do | |
| RSpec.describe 'shared/_header_navbar', type: :view do |
|
|
||
| it 'has nav links' do | ||
| render | ||
| expect(rendered).to have_selector '#user-util-collapse', text: 'links' |
There was a problem hiding this comment.
Do we need to have a view test at all? View tests are deprecated in rails. Instead can you use a request test, feature test, or a component test?
| <%= render blacklight_config.header_component.new(blacklight_config: blacklight_config) %> | ||
| <% else %> | ||
| <%= render Spotlight::HeaderComponent.new(blacklight_config: blacklight_config) %> | ||
| <% ActiveSupport::Deprecation.warn("_header_navbar.html.erb will be deprecated in future versions. Please use Blaclight configuration to specify your HeaderComponent.") %> |
There was a problem hiding this comment.
Suggested change
| <% ActiveSupport::Deprecation.warn("_header_navbar.html.erb will be deprecated in future versions. Please use Blaclight configuration to specify your HeaderComponent.") %> | |
| <% ActiveSupport::Deprecation.warn("_header_navbar.html.erb will be deprecated in future versions. Please use Blacklight configuration to specify your HeaderComponent.") %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Relates to having tests pass with Blacklight 8.3 and using a Spotlight HeaderComponent instead of shared/_header_navbar. The Spotlight header is almost exactly the same as the default Blacklight header except it does not include the search bar (which is elsewhere on the page).
Refer to #3047 and this comment which includes a checklist of tests to fix: #3047 (comment)
For 8.3, the following tests are failing:
What this pull request does
How to test
These tests should still pass in Blacklight 7.
How to test with Blacklight 8: Generate test app (.internal_test_app). Update the internal test app's Gemfile to use Blacklight 8.3. Run bundle install for the internal test app. Then run rspec ./spec/views/spotlight/pages/show.html.erb_spec.rb:46 and rspec ./spec/views/spotlight/pages/show.html.erb_spec.rb:50.