Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing inconsistent behavior for custom ports with schemes #367

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fixing inconsistent behavior for custom ports with schemes #367

merged 3 commits into from
Aug 17, 2021

Conversation

Mzack9999
Copy link
Member

No description provided.

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 16, 2021
@Mzack9999 Mzack9999 self-assigned this Aug 16, 2021
@Mzack9999 Mzack9999 linked an issue Aug 16, 2021 that may be closed by this pull request
[v1.1.1.1] Bug in multiple scheme input with ports flag #354
Closed
ehsandeep
ehsandeep reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st case:- FIXED

$echo 127.0.0.1 | ./httpx -silent -probe -ports http:8888,https:8888
https://127.0.0.1:8888 [FAILED]
http://127.0.0.1:8888 [SUCCESS]

2nd case:- NOT FIXED

$echo 127.0.0.1 | ./httpx -silent -probe -ports http:8888,https:8888,http:8888
http://127.0.0.1:8888 [SUCCESS]

@ehsandeep
Copy link
Member

works as expected:-

echo 127.0.0.1 | ./httpx -silent -probe -ports http:8888,https:8888,http:8888
https://127.0.0.1:8888 [FAILED]
http://127.0.0.1:8888 [SUCCESS]

echo 127.0.0.1 | ./httpx -silent -probe -ports http:8888,https:8888,http:8888,http:43434
http://127.0.0.1:43434 [FAILED]
https://127.0.0.1:8888 [FAILED]
http://127.0.0.1:8888 [SUCCESS]

@ehsandeep ehsandeep merged commit 4f7f352 into dev Aug 17, 2021
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Aug 17, 2021
@ehsandeep ehsandeep mentioned this pull request Aug 17, 2021
Closed
@ehsandeep ehsandeep deleted the 354-bugfix-custom-ports-with-scheme branch August 17, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.1.1.1] Bug in multiple scheme input with ports flag
2 participants
@Mzack9999 @ehsandeep