Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional test #436

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Functional test #436

merged 6 commits into from
Nov 18, 2021

Conversation

LuitelSamikshya
Copy link
Contributor

No description provided.

@LuitelSamikshya LuitelSamikshya self-assigned this Nov 17, 2021
@LuitelSamikshya LuitelSamikshya added Type: Enhancement Most issues will probably ask for additions or changes. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 17, 2021
@LuitelSamikshya LuitelSamikshya linked an issue Nov 17, 2021 that may be closed by this pull request
Functional test implementation #417
Closed
Mzack9999
Mzack9999 requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CLI args in functional test cases are missing the argument value

cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
cmd/functional-test/testcases.txt Outdated Show resolved Hide resolved
@ehsandeep ehsandeep merged commit f408ed6 into dev Nov 18, 2021
@ehsandeep ehsandeep deleted the functional-test branch November 18, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Review Needed The issue has a PR attached to it which needs to be reviewed Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functional test implementation
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999