Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove * and/or . (prefix) from target #452

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Remove * and/or . (prefix) from target #452

merged 3 commits into from
Dec 8, 2021

Conversation

parrasajad
Copy link
Contributor

to fix #447

@parrasajad parrasajad linked an issue Dec 6, 2021 that may be closed by this pull request
TLS probe discards entries starting with * #447
Closed
ehsandeep
ehsandeep requested changes Dec 6, 2021
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate input check in missing like httpx does in other cases.

$echo in.search.yahoo.com | ./httpx -silent -tls-probe | wc -l
78

$echo in.search.yahoo.com | ./httpx -silent -tls-probe | sort -u | wc -l
62

@Mzack9999 Mzack9999 added Type: Enhancement Most issues will probably ask for additions or changes. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 6, 2021
@Mzack9999
Copy link
Member

Mzack9999 commented Dec 6, 2021 •
edited
Loading

We can reuse the helper functions added to stream modality to avoid dupes:

httpx/runner/runner.go

Line 320 in d7e081c

func (r *Runner) setSeen(k string) {

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 8, 2021
@ehsandeep ehsandeep merged commit 7e80b77 into dev Dec 8, 2021
@ehsandeep ehsandeep deleted the tls-probe#447 branch December 8, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@parrasajad parrasajad

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS probe discards entries starting with *
3 participants
@parrasajad @Mzack9999 @ehsandeep