Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for custom resolvers #467

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Adding support for custom resolvers #467

merged 2 commits into from
Dec 29, 2021

Conversation

Mzack9999
Copy link
Member

This PR adds support for custom resolvers from CLI/File. Example:

$ cat resolvers.txt
1.1.1.1
$ echo aaaa | go run . -resolvers resolvers.txt,2.2.2.2

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 28, 2021
@Mzack9999 Mzack9999 self-assigned this Dec 28, 2021
@Mzack9999 Mzack9999 linked an issue Dec 28, 2021 that may be closed by this pull request
Custom resolver input support #449
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Dec 28, 2021
LuitelSamikshya
LuitelSamikshya approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ehsandeep ehsandeep merged commit 72ce90e into dev Dec 29, 2021
@ehsandeep ehsandeep deleted the issue-449-custom-resolvers branch December 29, 2021 10:04
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom resolver input support
3 participants
@Mzack9999 @ehsandeep @LuitelSamikshya