Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for favicon hash #476

Merged
merged 7 commits into from
Jan 7, 2022
Merged

Add support for favicon hash #476

merged 7 commits into from
Jan 7, 2022

Conversation

Mzack9999
Copy link
Member

This PR supports favicon extraction with a new flag -favicon. If used, the path will be modified to /favicon.ico. The resulting hash can be matched or filtered with:

-mfc, -match-favicon    Match Favicon hash
-ffc, -filter-favicon    Filter Favicon hash

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 3, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 3, 2022
@Mzack9999 Mzack9999 linked an issue Jan 3, 2022 that may be closed by this pull request
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 3, 2022
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mimic the hash calculation similar to shodan favicon to make it reusable and map new hashes.

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 4, 2022
@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Jan 4, 2022
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 7, 2022
@ehsandeep ehsandeep merged commit bee9643 into dev Jan 7, 2022
@ehsandeep ehsandeep deleted the issue-459-favicon branch January 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon hash probing
3 participants