Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSONSchema Libraries #4943

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Mar 25, 2024

Proposed changes

Addresses #3690 by switching the jsonschema from https://github.com/alecthomas/jsonschema to https://github.com/invopop/jsonschema due to the former being deprecated.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kchason kchason marked this pull request as ready for review March 25, 2024 20:40
@ehsandeep ehsandeep linked an issue Mar 26, 2024 that may be closed by this pull request
@GeorginaReeder
Copy link

Thanks for your contribution @kchason , we appreciate it!

@tarunKoyalwar
Copy link
Member

failed unit test is fixed in #4941 , will merge and refactor jsonschema on types + examples in follow-up pr

@tarunKoyalwar tarunKoyalwar merged commit c123a4b into projectdiscovery:dev Mar 27, 2024
9 of 12 checks passed
@kchason kchason deleted the 3690-replace-jsonschema branch March 27, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated github.com/alecthomas/jsonschema
3 participants