chore(deps): change to github.com/microsoft/go-mssqldb@v1.6.0 #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @Jarnpher553 , we appreciate it! We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments! |
|
Something went wrong, Windows testing failed. 😓 |
|
no worries @Jarnpher553 , it seems to be flaky , the integration test passed in debug mode |
ehsandeep
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change to github.com/microsoft/go-mssqldb@v1.6.0
Proposed changes
When my project uses github.com/microsoft/go-mssqldb, it conflicts with github.com/denisenkom/go-mssqldb used by nuclei, resulting in the error "panic: sql: Register called twice for driver mssql". The main reason for this issue is that both go-mssqldb packages register a driver with the same name mssql, so I would like to update denisenkom/go-mssqldb to microsoft/go-mssqldb.
Checklist