Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FileAuthProvider stores the same strategy for each entry #5474

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mrschyte
Copy link
Contributor

@mrschyte mrschyte commented Jul 31, 2024

Proposed changes

This commit fixes a bug in the FileAuthProvider class when there are multiple secret entries. Currently the same pointer is used for creating the authentication strategy and thus a single credential (that was loaded last) will be tried for each domain.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tarunKoyalwar tarunKoyalwar self-requested a review July 31, 2024 18:35
@GeorginaReeder
Copy link

Thanks so much for your contribution @mrschyte !

We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments!

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

i thought this was fixed with recent go 1.22 but it seems like we are not using go 1.22 yet https://go.dev/blog/loopvar-preview. similar issues should be automatically resolves once we bump go mod version to 1.22

@ehsandeep ehsandeep merged commit 350fa4c into projectdiscovery:dev Aug 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants