Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple auth strategies per target from secret file #5500

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add support for multiple auth strategies per target from secret file #5500

merged 1 commit into from
Aug 16, 2024

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Aug 8, 2024 •
edited
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M RamanaReddy0M self-assigned this Aug 8, 2024
dwisiswant0
dwisiswant0 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ehsandeep ehsandeep merged commit 2609d2d into dev Aug 16, 2024
12 checks passed
@ehsandeep ehsandeep deleted the issue-5498-use-all-domain-secrets branch August 16, 2024 06:29
@BrewTestBot BrewTestBot mentioned this pull request Aug 16, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Closed
@blsaccess blsaccess mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@dwisiswant0 dwisiswant0 dwisiswant0 approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only the last secret matching domain is used from a secret file
3 participants
@RamanaReddy0M @ehsandeep @dwisiswant0