Code smells #966
Merged
Code smells #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgedhallpass
added
the
Status: Review Needed
…ew error variables instead of re-using them
forgedhallpass
force-pushed
the
code_smells
branch
from
d3ba785
to
2988e95
Compare
Mzack9999
approved these changes
Sep 13, 2021
forgedhallpass
removed
the
Status: Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've identified all the places where a passed-in parameter is not used. This might suggest possible bugs, hence it would worth reviewing them. In case it is intentional, we should rename the parameter to
_. The fixes can be done within this branch.