Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go install support as fallback #194

Merged
merged 5 commits into from
Oct 9, 2023
Merged

add go install support as fallback #194

merged 5 commits into from
Oct 9, 2023

Conversation

dogancanbakir
Copy link
Member

Closes #193.

$ go run . -i notify

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

                projectdiscovery.io

[INF] Current pdtm version v0.0.8 (latest)
[ERR] error while installing notify: not implemented
[INF] trying to install notify using go install
[INF] successfully installed notify using go install

@dogancanbakir dogancanbakir self-assigned this Sep 5, 2023
@tarunKoyalwar tarunKoyalwar linked an issue Sep 21, 2023 that may be closed by this pull request
go install support as fallback #193
Closed
Mzack9999
Mzack9999 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update this with https://github.com/projectdiscovery/pdtm-api/issues/149

internal/runner/runner.go Outdated Show resolved Hide resolved
Mzack9999
Mzack9999 requested changes Sep 27, 2023
View reviewed changes
internal/runner/runner.go Outdated Show resolved Hide resolved
Mzack9999
Mzack9999 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ go run . -i notify

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

                projectdiscovery.io

[INF] Current pdtm version v0.0.8 (latest)
[INF] Run `source ~/.bashrc` to add /home/xxx/.pdtm/go/bin to $PATH 
[ERR] error while installing notify: not found
[INF] trying to install notify using go install
[INF] successfully installed notify using go install
$ ls /home/xxx/.pdtm/go/bin/notify 
/home/xxx/.pdtm/go/bin/notify

@dogancanbakir dogancanbakir mentioned this pull request Oct 4, 2023
Closed
@ehsandeep ehsandeep merged commit dfd3fd3 into dev Oct 9, 2023
9 checks passed
@ehsandeep ehsandeep deleted the goinstall_fallback branch October 9, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go install support as fallback
3 participants
@dogancanbakir @ehsandeep @Mzack9999