Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce install type #204

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Introduce install type #204

merged 7 commits into from
Oct 11, 2023

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Oct 9, 2023 •
edited
Loading

Closes #201.

$ go run . -i katana,nuclei

                ____
     ____  ____/ / /_____ ___
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/
 /_/

		projectdiscovery.io

[INF] Current pdtm version v0.0.8 (latest)
[INF] installing katana with go install...
[INF] installed katana 1.0.4 (latest)
[INF] installing nuclei...
[INF] installed nuclei 2.9.15 (latest)

@dogancanbakir dogancanbakir self-assigned this Oct 9, 2023
@dogancanbakir dogancanbakir linked an issue Oct 9, 2023 that may be closed by this pull request
Use go install for tools with dynamic linked libraries #201
Closed
Mzack9999
Mzack9999 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - It seems like api is still not deployed

@ehsandeep
Copy link
Member

@Mzack9999 @dogancanbakir, new changes are now live - https://api.pdtm.sh/api/v1/tools/aix

@dogancanbakir
Copy link
Member Author

@ehsandeep,
Thank you for deploying the changes. We can proceed with the merge now.

ehsandeep
ehsandeep requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

./pdtm -i katana

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

		projectdiscovery.io

[INF] Current pdtm version v0.0.8 (latest)
[INF] installing katana with go install...
[ERR] katana: go install failed

we can fallback to downloading binary in case of go is not available on system.

@ehsandeep ehsandeep merged commit 0aec3a0 into dev Oct 11, 2023
9 checks passed
@ehsandeep ehsandeep deleted the introduce_install_type branch October 11, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use go install for tools with dynamic linked libraries
3 participants
@dogancanbakir @ehsandeep @Mzack9999