Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support days unit while parsing time string #188

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Jun 27, 2023

time.ParseDuration valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".
Also support:
days unit => ex: "2d" => 2*24+"h"
default to sec => ex: "10" => 10s

@Mzack9999 Mzack9999 linked an issue Jun 27, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 merged commit eaf3001 into main Jun 27, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the improve-parse-duration branch June 27, 2023 12:12
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve time parsing
2 participants