Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async/await #195

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Add async/await #195

merged 1 commit into from
Jul 4, 2023

Conversation

Mzack9999
Copy link
Member

Closes #194

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jul 3, 2023
@Mzack9999 Mzack9999 self-assigned this Jul 3, 2023
@Mzack9999 Mzack9999 mentioned this pull request Jul 3, 2023
Closed
tarunKoyalwar
tarunKoyalwar approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

nice idea !! we can replace code like https://github.com/projectdiscovery/tlsx/blob/21f17764c006cc224faa64a381952a17b895762c/pkg/tlsx/ztls/ztls.go#L269-L285 with Future Now

@Mzack9999 Mzack9999 merged commit d5c2b3e into main Jul 4, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the feat-async branch July 4, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add async/await support
2 participants
@Mzack9999 @tarunKoyalwar