Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Add e2e benchmarks for head and block Queries #467

Merged

Conversation

krasi-georgiev
Copy link
Contributor

@krasi-georgiev krasi-georgiev commented Dec 10, 2018

closes #240
closes #278 already closed in #572

combined and refactored the above PRs.

will post results from the benchmarks shortly.

Signed-off-by: Krasi Georgiev kgeorgie@redhat.com

@krasi-georgiev
Copy link
Contributor Author

benchcmp no-expand.txt expand.txt
benchmark                                                                 old ns/op     new ns/op     delta
BenchmarkPersistedQueries_Series_1M_RESelector_1_Expansion-8              157304440     147421099     -6.28%
BenchmarkPersistedQueries_Series_1M_RESelector_2_Expansion-8              19163203      17982639      -6.16%
BenchmarkPersistedQueries_Series_1M_RESelector_3_Expansion-8              8640811       7914559       -8.40%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_1_Expansion-8      515304845     471832010     -8.44%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_2_Expansion-8      64759526      69743052      +7.70%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_3_Expansion-8      29525021      28743209      -2.65%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_1_Expansion-8     572205794     580150933     +1.39%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_2_Expansion-8     72159910      82287972      +14.04%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_3_Expansion-8     33388668      26196775      -21.54%

benchmark                                                                 old allocs     new allocs     delta
BenchmarkPersistedQueries_Series_1M_RESelector_1_Expansion-8              1000182        1000223        +0.00%
BenchmarkPersistedQueries_Series_1M_RESelector_2_Expansion-8              110304         110325         +0.02%
BenchmarkPersistedQueries_Series_1M_RESelector_3_Expansion-8              40215          40232          +0.04%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_1_Expansion-8      3100695        3100832        +0.00%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_2_Expansion-8      341929         341997         +0.02%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_3_Expansion-8      124624         124676         +0.04%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_1_Expansion-8     3100696        3100830        +0.00%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_2_Expansion-8     341929         341996         +0.02%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_3_Expansion-8     124624         124676         +0.04%

benchmark                                                                 old bytes     new bytes     delta
BenchmarkPersistedQueries_Series_1M_RESelector_1_Expansion-8              55219483      59879260      +8.44%
BenchmarkPersistedQueries_Series_1M_RESelector_2_Expansion-8              6081791       6468332       +6.36%
BenchmarkPersistedQueries_Series_1M_RESelector_3_Expansion-8              2208200       2324264       +5.26%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_1_Expansion-8      144936442     158922606     +9.65%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_2_Expansion-8      15965682      17126937      +7.27%
BenchmarkPersistedQueries_3Blocks_Series_1M_RESelector_3_Expansion-8      5801820       6150190       +6.00%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_1_Expansion-8     144937071     158921465     +9.65%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_2_Expansion-8     15965733      17126544      +7.27%
BenchmarkPersistedQueries_10Blocks_Series_1M_RESelector_3_Expansion-8     5801675       6150330       +6.01%

@krasi-georgiev
Copy link
Contributor Author

ping @codesome @gouthamve @brian-brazil
ready for review (thanks to @VladMasarik for fixing a small bug)

@brian-brazil
Copy link
Contributor

Hmm, I've some benchmarks in #572 also. We should de-duplicate a bit I think.

@krasi-georgiev krasi-georgiev changed the title Expand postings with benchmarks Add benchmarks Apr 10, 2019
querier_test.go Outdated Show resolved Hide resolved
@krasi-georgiev krasi-georgiev changed the title Add benchmarks [WIP] Add benchmarks Apr 10, 2019
naivewong added a commit to naivewong/tsdb that referenced this pull request May 17, 2019
Signed-off-by: naivewong <867245430@qq.com>
codesome pushed a commit that referenced this pull request May 27, 2019
* Original version of the set optimization

Signed-off-by: naivewong <867245430@qq.com>

* simple set matcher

Signed-off-by: naivewong <867245430@qq.com>

* simple set matcher

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* add benchmark

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update benchmark

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update benchmark

Signed-off-by: naivewong <867245430@qq.com>

* update benchmark

Signed-off-by: naivewong <867245430@qq.com>

* update benchmark

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>

* use genSeries from #467

Signed-off-by: naivewong <867245430@qq.com>

* update

Signed-off-by: naivewong <867245430@qq.com>
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
@krasi-georgiev krasi-georgiev changed the title [WIP] Add benchmarks Add e2e benchmarks for head and block Queries Jun 3, 2019
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
@krasi-georgiev
Copy link
Contributor Author

some extensive query benchmarks

cc @gouthamve @codesome

@krasi-georgiev
Copy link
Contributor Author

@brian-brazil couldn't have a quick look and let me know if you still think we should merge this with BenchmarkHeadPostingForMatchers

@brian-brazil
Copy link
Contributor

As I said on IRC there, it'd be best to run the postings benchmarks both ways.

@krasi-georgiev
Copy link
Contributor Author

What do you mean by both ways?

@brian-brazil
Copy link
Contributor

With just the head, and with blocks.

@krasi-georgiev
Copy link
Contributor Author

These benchmarks also test head and blocks completely separately.
https://github.com/prometheus/tsdb/pull/467/files#diff-a1431a302431f51c7f9e7c0b3cb58ed0R2197

I also don't mind to keep these separately.

@brian-brazil
Copy link
Contributor

Ah right, I'd missed that.

@brian-brazil
Copy link
Contributor

👍

@krasi-georgiev krasi-georgiev merged commit e809cb4 into prometheus-junkyard:master Jun 7, 2019
@krasi-georgiev krasi-georgiev deleted the 278-refactored branch June 7, 2019 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants