Update logging #3097
Merged
Update logging #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/promslog
branch
6 times, most recently
from
8a80711
to
79cc810
Compare
|
👓 @tjhop |
tjhop
suggested changes
Sep 11, 2024
There was a problem hiding this comment.
Looks great to me (aside from the comment about the test fixtures, and the build updates -- unsure if we'd rather separate those bits).
Can we also enable the sloglint linter in golanci-lint? It's disabled by default:
Lines 2 to 5 in b9d0932
| @@ -130,7 +128,7 @@ func (h *handler) innerHandler(filters ...string) (http.Handler, error) { | |||
| handler = promhttp.HandlerFor( | |||
| prometheus.Gatherers{h.exporterMetricsRegistry, r}, | |||
| promhttp.HandlerOpts{ | |||
| ErrorLog: stdlog.New(log.NewStdlibAdapter(level.Error(h.logger)), "", 0), | |||
| ErrorLog: slog.NewLogLogger(h.logger.Handler(), slog.LevelError), | |||
Merged
SuperQ
force-pushed
the
superq/promslog
branch
from
79cc810
to
63e3c2e
Compare
Switch from promlog/go-kit to promslog/slog for logging. * Update Go build to 1.23. Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/promslog
branch
from
63e3c2e
to
c1a6f9a
Compare
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Sync dependencies and log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
added a commit
to rexagod/node_exporter
that referenced
this pull request
Sep 22, 2024
Log using the machinery introduced in prometheus#3097. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
SuperQ
pushed a commit
that referenced
this pull request
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from promlog/go-kit to promslog/slog for logging.