-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v2.52.0-rc.0 release #13969
Prepare v2.52.0-rc.0 release #13969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, a couple of suggestions, thanks!
40a7376
to
6698159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We spent some time syncing with @ArthurSens resulting in those notes
* [BUGFIX] Scrape: Fix setting native histogram schema factor during scrape. #13846 | ||
* [BUGFIX] TSDB: Fix counting of histogram samples when creating WAL checkpoint stats. #13776 | ||
* [BUGFIX] TSDB: Avoid compacting empty heads. #13755 | ||
* [BUGFIX] TSDB: Count float histograms in WAL checkpoint. #13844 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make it a feature or join with stats bugfix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking again about this, one is counting in WAL checkpoint and the other is counting in query stats... I'm not sure if it makes sense to join them in a single changelog entry
6698159
to
f6eb83c
Compare
/prombench v2.51.2 |
@ArthurSens is not a org member nor a collaborator and cannot execute benchmarks. |
/prombench v2.51.2 |
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
f6eb83c
to
9195d51
Compare
Benchmark tests are running for 3 days! If this is intended ignore this message otherwise you can cancel it by commenting: |
/prombench cancel |
Benchmark cancel is in progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit sketchy, there is a slight different in tail latency for queries, but perhaps negligible.
Either we stop release and try to bisect what optimization could cause this OR we proceed and optimize later when (if) users will be actually affected by this, ideally in RC phase. Happy with either option.
Hmmm, I didn't notice the compaction happening at the same time, but the compaction happens for both versions and only 1 spikes. The uneven query distribution sounds like a good explanation tho I feel like this release candidate was delayed enough already, let's try publishing it and see if we get more feedback about slow queries. |
There were a few entries which I was not sure what to announce. Please let me know if you have better suggestions :)