persistent connections working again

[prgTW]

Persistent connections are available again by not overriding PDO statement class

fixes this error:

Warning: PDO::setAttribute(): SQLSTATE[HY000]: General error: PDO::ATTR_STATEMENT_CLASS cannot be used with persistent PDO instances

ref: #1225

[marcj]

We should rather completely drop Propel\Runtime\Adapter\Pdo\PdoStatement instead of using it only for HHVM.

[staabm]

alternatively we should drop HHVM support. not sure this runtime is relevant for somebody.

[marcj]

or both :P

[prgTW]

With this PR I wanted only to make persistent connections available again and didn't want to alter HHVM in any way cause I don't use it and don't have it and didn't want to make any backward-incompatible changes. Droping HHVM support could be a separate PR though

[prgTW]

so ... any other thoughts about merging this one and restoring persistent connections in propel?

[marcj]

What do you mean by dropping hhvm support? This drops basically the overwritten class support, for whatever that was used. Let us just fix it the right way and remove Propel\Runtime\Adapter\Pdo\PdoStatement completely, instead of using it only for hhvm.

[prgTW]

@marcj I removed Propel\Runtime\Adapter\Pdo\PdoStatement class as You suggested

[marcj]

I guess this interface Propel\Runtime\Connection\StatementInterface is not used somewhere as well.

[prgTW]

actually it's used in quite few places, shouldn't it's usages be converted to usages of \PdoStatement as well, am I getting You right?

[marcj]

Yes, you're right.

[prgTW]

removed

[marcj]

Nice, good work, thanks!

[prgTW]

great news, thank you too :)

[marcj]

Backported to data-mapper branch.

[kinekt4]

Hi guys.

This pull request broke something that used to work: #1413

In composer.json, I've currently had to make sure propel use the commit prior to this:

"propel/propel": "dev-master#38f1044e9b57cb7f68b59224f1830bde7009673f"

Does anyone have a workaround so I don't have to be stuck on this commit?