Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting warnings because declarations of
setPrimaryKey()
do not match between extending classes:setPrimaryKey(?int $key = NULL): void vs
setPrimaryKey($pk): void
I am extending tables via concrete_inheritance behavior, and the parent table does not have a primary key. Apparently this leads to the parent class having a stub for setPrimaryKey(), which is defined differently than the function on the child class. Since the parent class has not PK declaration itself, and can be parent to tables with different PK types, it is not possible to insert a type hint there.
Fortunately, adding
setPrimaryKey()
to tables without PK has been marked as deprecated since 2011, so I think the problem can be easily solved by just removing that function.