UUID adjustments for mariadb #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.25% // Head: 88.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
=============================================
+ Coverage 73.25% 88.36% +15.11%
- Complexity 7917 7922 +5
=============================================
Files 227 227
Lines 21133 21156 +23
=============================================
+ Hits 15480 18694 +3214
+ Misses 5653 2462 -3191
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
asmarovydlo
approved these changes
Dec 19, 2022
| $this->tableEngineKeyword = $tableEngineKeyword; | ||
| } | ||
| if ($uuidColumnType = $mysqlConfig['uuidColumnType']) { | ||
| $enable = strtolower($uuidColumnType) === 'native'; |
There was a problem hiding this comment.
[Minor] Wouldn't be better to have a standalone platform for MariaDb that extends a MySQL one?
There was a problem hiding this comment.
Yes, that would be great, but that is its own PR
dereuromark
changed the title
nicolanrizzo
added a commit
to nicolanrizzo/PropelBundle
that referenced
this pull request
Apr 25, 2024
nicolanrizzo
added a commit
to nicolanrizzo/PropelBundle
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use native uuid type on MariaDB by enabling it in the propel configuration:
While the actual change is quite small, I had to went through a lot of places to find a suitable entry point. I had to refactor some methods along the way, and I think it is best to keep these changes. I have put them in different commits if this helps reviewing!
Also, this includes #1922 , agnostic tests are running