Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS by removing inline assignments. #1946

Merged
merged 7 commits into from
Jan 20, 2023

Conversation

michbeck
Copy link
Contributor

@michbeck michbeck commented Jan 19, 2023

Follow of #1945 for #1921

@michbeck michbeck changed the title Fixed inline assignments Fix CS by removing inline assignments. Jan 19, 2023
Copy link
Contributor

@mringler mringler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dereuromark
Copy link
Contributor

The order in some cases cannot change
Otherwise this creates Bugs. Some of this can be seen in current test fails, others might Fall through the Cracks of CI and code review

@codecov-commenter
Copy link

Codecov Report

Base: 88.69% // Head: 88.65% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (c530d59) compared to base (8aa4f2b).
Patch coverage: 84.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1946      +/-   ##
============================================
- Coverage     88.69%   88.65%   -0.04%     
- Complexity     8002     8017      +15     
============================================
  Files           243      243              
  Lines         24474    24542      +68     
============================================
+ Hits          21706    21758      +52     
- Misses         2768     2784      +16     
Flag Coverage Δ
5-max 88.65% <84.66%> (-0.04%) ⬇️
7.4 88.65% <84.66%> (-0.04%) ⬇️
agnostic 67.44% <77.33%> (+0.01%) ⬆️
mysql 69.17% <40.66%> (-0.13%) ⬇️
pgsql 69.18% <42.00%> (-0.14%) ⬇️
sqlite 67.18% <40.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Propel/Generator/Behavior/I18n/I18nBehavior.php 95.83% <ø> (ø)
src/Propel/Generator/Platform/MysqlPlatform.php 95.69% <ø> (ø)
src/Propel/Generator/Reverse/MysqlSchemaParser.php 90.00% <ø> (ø)
src/Propel/Generator/Reverse/PgsqlSchemaParser.php 90.15% <ø> (-0.04%) ⬇️
src/Propel/Generator/Model/Diff/DatabaseDiff.php 64.28% <32.25%> (-8.84%) ⬇️
...rator/Behavior/Versionable/VersionableBehavior.php 85.31% <83.33%> (-1.40%) ⬇️
src/Propel/Generator/Builder/Om/ObjectBuilder.php 93.86% <100.00%> (+<0.01%) ⬆️
...rc/Propel/Generator/Builder/Om/TableMapBuilder.php 94.54% <100.00%> (+0.13%) ⬆️
src/Propel/Generator/Config/GeneratorConfig.php 97.11% <100.00%> (+0.02%) ⬆️
src/Propel/Generator/Model/Behavior.php 86.17% <100.00%> (+0.14%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereuromark dereuromark merged commit 521dbe2 into propelorm:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants