Fix up datetime PHPStan error. #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mringler
approved these changes
Jan 20, 2023
src/Propel/Generator/Behavior/Sortable/SortableBehaviorObjectBuilderModifier.php
Show resolved
Hide resolved
| @@ -49,6 +49,7 @@ public function getDataObject() | |||
| */ | |||
| public function fetchColumn($index = null) | |||
| { | |||
| /** @var array|null $next */ | |||
There was a problem hiding this comment.
I think fetch() returns false if there are no more columns to fetch
There was a problem hiding this comment.
Yeah, we could check on this. I just thought in this context it seems impossible (theoretical problem).
There was a problem hiding this comment.
I think the check happens in the next line:
if (!$next) {
return null;
}There was a problem hiding this comment.
Documented is array|bool|null
The bool true is the problem here
And instead of just checking on this, I simplified to the expected outcome as docblock.
michbeck
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix some PHPStan issues of level 7