Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Symfony v7 #1992

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Conversation

Leonardo-Atalla
Copy link
Contributor

No description provided.

@Leonardo-Atalla Leonardo-Atalla marked this pull request as draft February 8, 2024 14:57
…nications/Propel2 into allow_symfony_7

# Conflicts:
#	src/Propel/Runtime/Validator/Constraints/Date.php
#	tests/Propel/Tests/Common/Config/Loader/FileLoaderTest.php
@Leonardo-Atalla Leonardo-Atalla marked this pull request as ready for review February 15, 2024 15:35
@pableu
Copy link
Contributor

pableu commented Feb 17, 2024

Can we get this merged and tag a new beta version @PhilinTv?

@pableu
Copy link
Contributor

pableu commented Feb 23, 2024

@dereuromark?

"symfony/finder": "^4.4.0 || ^5.0.0 || ^6.0.0",
"symfony/translation": "^4.4.0 || ^5.0.0 || ^6.0.0",
"symfony/validator": "^4.4.0 || ^5.0.0 || ^6.0.0"
"symfony/yaml": "^4.4.0 || ^5.0.0 || ^6.0.0 || ^7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like the right time to drop 4x support 😈

Copy link
Contributor

@PhilinTv PhilinTv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Clean and clear 💎

@PhilinTv PhilinTv merged commit f4889ff into propelorm:master Mar 23, 2024
45 checks passed
@Leonardo-Atalla
Copy link
Contributor Author

Thank you @PhilinTv, thank you, @pableu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants