Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save files using format-specific extensions. #1016

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Save files using format-specific extensions. #1016

merged 1 commit into from
Jul 26, 2021

Conversation

gouttegd
Copy link
Collaborator

This PR makes Protégé save a new ontology in a file with an extension suitable to the format chosen by the user, instead of systematically using a ".owl" extension regardless of the format.

It attempts to centralise the association between a format and its extensions in a new static Extensions class, which can then be used both when saving a new file (to only allow extensions matching the intended save format) and when opening a file (to allow all extensions for all supported formats).

Related to #969, #1012, and #1015.

When saving an ontology, use extensions suitable to the format chosen
by the user instead of systematically using ".owl".
@matthewhorridge matthewhorridge self-requested a review July 26, 2021 16:28
@matthewhorridge matthewhorridge self-assigned this Jul 26, 2021
@matthewhorridge matthewhorridge added the Status: Needs Review Indicates that a code change, in a branch/PR, needs to be reviewed label Jul 26, 2021
@matthewhorridge matthewhorridge added this to the Protégé 5.6.0 milestone Jul 26, 2021
@matthewhorridge
Copy link
Contributor

This looks great. Thanks so much for the contribution @gouttegd!

@matthewhorridge matthewhorridge merged commit eae3656 into protegeproject:master Jul 26, 2021
@matthewhorridge matthewhorridge removed the Status: Needs Review Indicates that a code change, in a branch/PR, needs to be reviewed label Jul 26, 2021
@gouttegd gouttegd deleted the priv/file-extensions branch July 26, 2021 17:03
@jmkeil
Copy link
Contributor

jmkeil commented Jul 26, 2021

That is great. Thank you.

Please not a small correction: #1017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants