Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for ORCiD #1053

Merged
merged 2 commits into from
May 23, 2022
Merged

Use HTTPS for ORCiD #1053

merged 2 commits into from
May 23, 2022

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Apr 29, 2022

Closes #1045
CC @matentzn

ORCiD's standard is to use HTTPS, this PR updates the construction of URIs to reflect this.

@cthoyt
Copy link
Contributor Author

cthoyt commented May 23, 2022

@matthewhorridge is there anything you need before you can give a review and merge this?

@matthewhorridge
Copy link
Contributor

Sorry @cthoyt ... will look at it asap

Copy link
Contributor

@matthewhorridge matthewhorridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@matthewhorridge matthewhorridge merged commit c3f7602 into protegeproject:master May 23, 2022
@matthewhorridge
Copy link
Contributor

Thanks for the contribution @cthoyt. We really appreciate it!

@cthoyt cthoyt deleted the patch-1 branch May 23, 2022 17:42
@cthoyt
Copy link
Contributor Author

cthoyt commented May 23, 2022

Thanks for the quick response! What's the timeline/process on making a new release with these changes?

@matthewhorridge
Copy link
Contributor

There's two major things to do (as far as I can tell)....

  • Upgrade the OWL API
  • Upgrade Java

Hoping to sort this out by the end of next week, time permitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORCiDs should be compiled to https rather than http when auto-generating annotations
2 participants