Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle nullability for optional fields #2011

Merged
merged 26 commits into from
Aug 13, 2024
Merged

fix: handle nullability for optional fields #2011

merged 26 commits into from
Aug 13, 2024

Commits on Jul 24, 2024

  1. Fixes optional handling for class-level comments (JS) and interfaces … 

    …(TS)
    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b38a668 View commit details
    Browse the repository at this point in the history

  2. Hide the fix for PB3 optional type declarations behind the flag --pb3… 

    …-optional
    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    358d336 View commit details
    Browse the repository at this point in the history

  3. Do not use null-defaults to decide type signature for pb3-optionals (… 

    …this only sets the default of optional fields, it doesn't control whether a field is optional or not)
    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    94556f9 View commit details
    Browse the repository at this point in the history

  4. New implementation that explicitly respects the optional keyword

    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2bd0b43 View commit details
    Browse the repository at this point in the history

  5. Fix options list in pbjs

    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4793755 View commit details
    Browse the repository at this point in the history

  6. Add tests for handling optional fields in both proto2 and proto3 syntax

    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f2a69a5 View commit details
    Browse the repository at this point in the history

  7. Explicit handling of proto3 syntax in the parser and static generator

    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    996e445 View commit details
    Browse the repository at this point in the history

  8. Only look up proto syntax once per type in the static generator

    @martin-traverse
    martin-traverse committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    aa61793 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fix lint warnings

    @martin-traverse
    martin-traverse committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f2ed6e0 View commit details
    Browse the repository at this point in the history

  2. Use field options in proto3 instead of adding an extra property

    @martin-traverse
    martin-traverse committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    856af47 View commit details
    Browse the repository at this point in the history

  3. Do not require repeated or map fields in the object properties (i.e. … 

    …for interface types)
    @martin-traverse
    martin-traverse committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ccd640e View commit details
    Browse the repository at this point in the history

  4. Do not generate doc comments for virtual oneOfs

    @martin-traverse
    martin-traverse committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    09f577a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Address codestyle comment (braces for if/else)

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6204b2d View commit details
    Browse the repository at this point in the history

  2. Address comment for default syntax

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    31f85e9 View commit details
    Browse the repository at this point in the history

  3. Change config flag to --null-semantics and update comments

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ed5980c View commit details
    Browse the repository at this point in the history

  4. Update PBJS and README for new --null-semantics flag

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    bee997d View commit details
    Browse the repository at this point in the history

  5. Update tests for --null-semantics flag

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    dee3083 View commit details
    Browse the repository at this point in the history

  6. Fix one lint warning

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    50255d0 View commit details
    Browse the repository at this point in the history

  7. Include tests for interface / message types under --null-semantics

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    623477b View commit details
    Browse the repository at this point in the history

  8. Implement propagation of interface / message types under --null-seman… 

    …tics flag
    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d5700a5 View commit details
    Browse the repository at this point in the history

  9. Update CLI options help and README

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9bcc006 View commit details
    Browse the repository at this point in the history

  10. Allow for other syntax options than "proto2" or "proto3"

    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fda51db View commit details
    Browse the repository at this point in the history

  11. Make parentIsInterface default to false in toJsType() 

    Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
    @martin-traverse @danielbankhead
    martin-traverse and danielbankhead committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8e0027a View commit details
    Browse the repository at this point in the history

  12. Allow undefined values (but not nulls) for implicit presence fields i… 

    …n properties / interfaces
    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    94bfbbc View commit details
    Browse the repository at this point in the history

  13. Update tests for proto3 to let implicit members be optional but not n… 

    …ullable
    @martin-traverse
    martin-traverse committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    258679c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Add braces to if/else clauses for readability on all code touched by … 

    …this change
    Martin Traverse committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c478e1f View commit details
    Browse the repository at this point in the history