Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Replace concurrency setup with max-parallel=1 strategy in copy-workflow #243

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Dec 10, 2021

With current concurrency setup only the first and the last matrix job was run and the rest were cancelled with Canceling since a higher priority waiting request for 'copy-*' exists.

The concurrency documentations explains this as follows:

Any previously pending job or workflow in the concurrency group will be canceled.

I think settings strategy.max-parallel: 1 in copy-workflow might do what we want it to which is to run all the matrix jobs within one copy-workflow instance sequentially: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategymax-parallel

One thing to watch out for is if the job sequence will continue after a failure but I think it will because of the fail-fast: false setting.

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my understanding:

  • With ~180 repos, we'll end up with 9 copy workflows.
  • In each of these copy workflows, only one job is running.
    That means, we'll have a max of 9 concurrent deployments running.

@galargh
Copy link
Contributor Author

galargh commented Dec 10, 2021

I've verified that max-parallel: 1 + fail-fast: false work as we expect it to: https://github.com/protocol/cache-go-action/runs/4482926137?check_suite_focus=true

@galargh galargh merged commit b69bd2a into master Dec 10, 2021
@galargh galargh deleted the clean-concurrency branch December 10, 2021 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants