Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Issue Labels #90

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Issue Labels #90

wants to merge 5 commits into from

Conversation

Stebalien
Copy link
Member

These issue labels were imported from https://github.com/ipfs/community/raw/master/ISSUE_LABELS.md (with slight modifications) which was originally adapted from https://github.com/libp2p/libp2p/blob/master/ISSUE-LABELLING.md.

  • The status/duplicate label was dropped. This is really a resolution, not a status. Duplicate issues are closed with a comment anyways so this label doesn't help much.
  • The status/deferred label was dropped. Priorities should be communicated through the P* labels. Any P2 & P3 issues are effectively "deferred".
  • The "difficulty" labels were renamed to "exp" for expertise to match how we use them. These labels now communicate the amount of experience with a system/repo required to tackle the issue.
  • I've added a few more topic labels, but most of these will be defined on a per-repo basis.

This patch also contains a GitHub Action to verify that all issue labels have been updated upstream in the protocol/.github repo. In the future, I'd like to partially automate this update process. Unfortunately, handling renames is a bit tricky so we're going to have to keep these two lists in sync for now.

@github-actions github-actions bot requested a review from BigLep March 27, 2021 00:01
@Stebalien
Copy link
Member Author

I guess the obvious question is: is this the right repo for this label taxonomy? We need a consistent place for it given that we're now a single team working across 5 different orgs.

This action compares the labels defined in this repo with those
specified in the protocol/.github repo.
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - great work!

proposals/dev-network-testsuite.md Outdated Show resolved Hide resolved
ISSUE_LABELS.md Outdated
| `kind/bug` | A bug in existing code (including security flaws) | `#fc2929` |
| `kind/discussion` | Topical discussion; usually not changes to codebase | `#c7def8` |
| `kind/enhancement` | A net-new feature or improvement to an existing feature | `#c7def8` |
| `kind/maintenance` | Work required to avoid breaking changes or harm to project's status quo | `#c7def8` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we going to add a note to be more specific here? Maybe something about "Build systems, dependency upgrades, CI."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. The current description better describes "tech debt" which probably deserves a different label.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to split this into:

  • kind/maintenance: CI, labeling, permissions.
  • kind/cleanup (or kind/debt): Cleanup, refactors, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@mikeal
Copy link
Contributor

mikeal commented Mar 30, 2021

Most of these labels don’t apply well to a repo that isn’t code and having a long list of unused labels will make labelling more difficult.

@Stebalien
Copy link
Member Author

Most of these labels don’t apply well to a repo that isn’t code and having a long list of unused labels will make labelling more difficult.

For now, I'm happy to apply these labels to code repos only (by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants