Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: Don't assume RepeatedField->array is not NULL #12899

Closed
wants to merge 1 commit into from
Closed

ruby: Don't assume RepeatedField->array is not NULL #12899

wants to merge 1 commit into from

Conversation

casperisfine
Copy link
Contributor

It's initially set as NULL and in corner cases it may not be initialized yet when we check its size.

Ref: #12216 (comment)

cc @haberman

@byroot
ruby: Don't assume RepeatedField->array is not NULL
206d477 
It's initially set as NULL and in corner cases it may not be
initialized yet when we check its size.
@casperisfine casperisfine requested a review from a team as a code owner May 25, 2023 08:09
@casperisfine casperisfine requested review from JasonLunn and removed request for a team May 25, 2023 08:09
@haberman
Copy link
Member

I want to understand what causes this to happen. I think this is probably not the right fix.

Do you remember how you triggered this bug?

@casperisfine
Copy link
Contributor Author

Do you remember how you triggered this bug?

I don't, it was a bit too long ago, sorry :/

@hlopko
Copy link
Contributor

hlopko commented May 30, 2023

@haberman how do you want to proceed? Would you consider accepting this PR, or should we close it as not having enough information to justify it?

@hlopko hlopko added bug ruby 🅰️ safe for tests Mark a commit as safe to run presubmits over labels May 30, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 30, 2023
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 12, 2023
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.

This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonLunn JasonLunn Awaiting requested review from JasonLunn JasonLunn is a code owner automatically assigned from protocolbuffers/protobuf-ruby

Assignees
No one assigned
Labels
bug inactive Denotes the issue/PR has not seen activity in the last 90 days. ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@casperisfine @haberman @hlopko @byroot