Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding USE_SECONDARY_MAP #12933

Closed

Conversation

opsengine
Copy link

@opsengine opsengine commented May 30, 2023

Make USE_SECONDARY_MAP configurable to mitigate #11968

Need to add a way to propagate the macro as a build flag from bundle.

@opsengine opsengine requested a review from a team as a code owner May 30, 2023 22:32
@opsengine opsengine requested review from JasonLunn and removed request for a team May 30, 2023 22:32
@google-cla
Copy link

google-cla bot commented May 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JasonLunn JasonLunn requested review from haberman and removed request for JasonLunn May 30, 2023 22:52
@fowles fowles added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 31, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 31, 2023
@hlopko hlopko added 🅰️ safe for tests Mark a commit as safe to run presubmits over ruby labels Jun 1, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jun 1, 2023
@haberman
Copy link
Member

haberman commented Jun 8, 2023

Please add the test case #11968 as a unit test, and enable USE_SECONDARY_MAP by default.

We can make it conditional again when/if we have a fix that can pass the test.

Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 11, 2023
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.

This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days. ruby wait for user action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants