Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/authz #266

Closed
wants to merge 8 commits into from
Closed

Feature/authz #266

wants to merge 8 commits into from

Conversation

arnabmitra
Copy link
Contributor

@arnabmitra arnabmitra commented Apr 26, 2021

Description

closes: #265


THIS PR is mainly a POC and a WIP for now

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@iramiller
Copy link
Member

Is the intention here to fork the authz module?

@arnabmitra
Copy link
Contributor Author

Is the intention here to fork the authz module?

Not i nhe future. or i would like not to.

however in this approach i did have to update the update grant method to be public,
that is the only fork/change other than release was not available when i started and wasm will have issues unless it uses 0.43

un exported func func (k Keeper) update(ctx sdk.Context, grantee sdk.AccAddress, granter sdk.AccAddress, updated exported.Authorization) error {
which is used.

that too does not require a full fork, we could just have our method.

@iramiller iramiller closed this Jul 27, 2021
@iramiller iramiller deleted the feature/authz branch March 21, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate authz module into provenance and use it to transfer restricted marker's
2 participants