REST VC metrics #13588
Merged
REST VC metrics #13588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
There was a problem hiding this comment.
For what it's worth, the current implementation for gRPC has two pairs of counter metrics tracking on the client side.
- unary requests (started_total, handled_total)
- stream requests (started_total, handled_total)
Then it has three histograms
- client handled (unary requests)
- client stream sent
- client stream received
All of these have three labels []string{"grpc_type", "grpc_service", "grpc_method"}) and sometimes a fourth label grpc_code.
With all of that, I would suggest that we mirror that in the implementation here for http.
Counters:
- Total number of RPCs started on the client (labels = "type", "service", "method")
- Total number of RPCs completed by the client, regardless of success or failure. (labels = "type", "service", "method", "code")
Histograms
- Histogram of response latency (seconds) of the RPC until it is finished by the application. (labels = "type", "service", "method")
# Conflicts: # beacon-chain/node/node.go # beacon-chain/rpc/service.go # beacon-chain/rpc/service_test.go
rkapka
commented
Feb 16, 2024
| var ( | ||
| httpRequestLatency = promauto.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Name: "http_request_latency_seconds", |
There was a problem hiding this comment.
promhttp measures seconds
# Conflicts: # beacon-chain/rpc/service.go # beacon-chain/rpc/service_test.go # validator/client/beacon-api/beacon_api_validator_client.go
# Conflicts: # beacon-chain/rpc/service.go
prestonvanloon
approved these changes
Mar 5, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.