Clean Up Deposit Processing Logs #13611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
potuz
requested changes
Feb 13, 2024
| "merkleTreeIndex": index, | ||
| }).Debug("Deposit registered from deposit contract") | ||
| // Log the deposit received periodically | ||
| if index%depositLoggingInterval == 0 { |
There was a problem hiding this comment.
You need to deal with the case when depositLoggingInterval is zero
| validDepositsCount.Inc() | ||
| // Notify users what is going on, from time to time. | ||
| if !s.chainStartData.Chainstarted { | ||
| deposits := len(s.chainStartData.ChainstartDeposits) | ||
| if deposits%512 == 0 { | ||
| if deposits%depositLoggingInterval == 0 { |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
This PR cleans up our deposit processing logs with an interval of 1024.
Which issues(s) does this PR fix?
Fixes #13548
Other notes for review