Slasher: Reduce cold start duration. #13620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
changed the title
nalepae
changed the title
nalepae
force-pushed
the
slasher-13430
branch
from
8a195f1
to
3236e48
Compare
rauljordan
previously approved these changes
Feb 15, 2024
And add a bunch of tests.
Before this commit, on a slasher cold boot (aka, without any db), the `updatedChunkByChunkIndex` function looped for all validators AND for all epochs between the genesis epoch and the current epoch. This could take several dozen of minutes, and it is useless since the min/max spans are actually a circular buffer with a limited lenght. Cells of min/max spans can be overwritten (with the same value) plenty of times. After this commit, the `updatedChunkByChunkIndex` function loops for all validators AND AT most 'historyLength' lenght. Every cell of min/max spans are written AT MOST once. Time needed for slasher boot goes from `O(nm)` to "only" `O(m)`, where: - `n` is the number of epochs since the genesis. - `m` is the number of validators.
nalepae
force-pushed
the
slasher-13430
branch
from
3236e48
to
f559e63
Compare
nisdas
approved these changes
Feb 16, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read commit by commit.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Improve slasher cold boot duration.
Before this commit, on a slasher cold boot (aka, without any db),
the
updatedChunkByChunkIndexfunction looped for all validatorsAND for all epochs between the genesis epoch and the current epoch.
This could take several dozen of minutes, and it is useless since the
min/max spans are actually a circular buffer with a limited lenght.
Cells of min/max spans can be overwritten (with the same value)
plenty of times.
After this commit, the
updatedChunkByChunkIndexfunction loopsfor all validators AND AT MOST
historyLengthlenght.Every cell of min/max spans are written AT MOST once.
Time needed for slasher boot goes from
O(nm) to "only"O(m), where:nis the number of epochs since the genesis.mis the number of validators.Which issues(s) does this PR fix?