Normalize backfill logs/errors #13642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
nalepae
previously approved these changes
Feb 21, 2024
rkapka
force-pushed
the
backfill-logs
branch
from
d600bb2
to
b5c4f79
Compare
kasey
reviewed
Feb 21, 2024
beacon-chain/sync/backfill/log.go
Outdated
|
|
||
| import "github.com/sirupsen/logrus" | ||
|
|
||
| var log = logrus.WithField("prefix", "backfill-sync") |
There was a problem hiding this comment.
Can we call this backfill to match the package name?
kasey
reviewed
Feb 21, 2024
| @@ -12,7 +12,7 @@ var ( | |||
| // This flag will be removed onced backfill is enabled by default. | |||
| EnableExperimentalBackfill = &cli.BoolFlag{ | |||
| Name: "enable-experimental-backfill", | |||
| Usage: "Backfill is still experimental at this time." + | |||
| Usage: "Backfill is still experimental at this time. " + | |||
There was a problem hiding this comment.
There is a second sentence
terencechain
approved these changes
Feb 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Makes backfill logs and errors consistent with the rest of the system:
log.gofile with a common prefixedlogvariableI also found some typos in flag descriptions