Optimize Adding Dirty Indices #13660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
requested changes
Feb 23, 2024
| if totalIndicesLen > indicesLimit { | ||
| b.dirtyIndices[index] = slice.SetUint64(b.dirtyIndices[index]) | ||
| } | ||
| totalIndicesLen = len(b.dirtyIndices[index]) + len(indices) |
There was a problem hiding this comment.
No need to recompute this if the above if wasn't hit, so please move this up within the if branch
potuz
approved these changes
Feb 24, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
We optimize how we add dirty indices for a particular field. In the event we do hit our indices limit, we attempt to remove duplicates before determining whether or not to rebuild the trie. This helps in prevent us from unnecessarily rebuilding a whole field trie.
Which issues(s) does this PR fix?
N.A
Other notes for review