Ignore Pubsub Messages Hitting Context Deadlines #13716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
terencechain
approved these changes
Mar 11, 2024
| @@ -286,6 +286,11 @@ func (s *Service) wrapAndReportValidation(topic string, v wrappedVal) (string, p | |||
| return pubsub.ValidationIgnore | |||
| } | |||
| b, err := v(ctx, pid, msg) | |||
| // We do not penalize peers if we are hitting pubsub timeouts | |||
| // trying to process those messages. | |||
| if b == pubsub.ValidationReject && ctx.Err() != nil { | |||
There was a problem hiding this comment.
Besides timeouts, this also implies context cancelled which is still good. We don't want to Reject and penalize a peer when a context is cancelled
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event we hit a context deadline processing a message, we do not reject that message and penalize the peer. Instead we simply ignore and drop them.
Which issues(s) does this PR fix?
N.A
Other notes for review