Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec test coverage report hack #13718

Merged
merged 24 commits into from
Mar 25, 2024
Merged

Spec test coverage report hack #13718

merged 24 commits into from
Mar 25, 2024

Conversation

saolyn
Copy link
Contributor

@saolyn saolyn commented Mar 11, 2024

What type of PR is this?

Test Coverage

What does this PR do? Why is it needed?

This PR adds a hack script to generating a spec test coverage report.
We basically run the bazel tests and save the test paths to bazels undeclared outputs folder. From there we cross reference the test paths with those of the official consensus spec tests repo and write to a file whether they have been found or are missing.

This is needed so that we can quickly determine whether there are any new spectests that we aren't supporting or if there are some spectests that we do support but are being skipped/not running.

Fail conditions are:

  1. If there is a test in the spec repo that we do not support and is not in the exclusions list
  2. A test in the exclusion list is being run

Which issues(s) does this PR fix?

N/A

Other notes for review

@saolyn saolyn requested a review from a team as a code owner March 11, 2024 15:37
@prestonvanloon prestonvanloon self-assigned this Mar 12, 2024
@saolyn saolyn mentioned this pull request Mar 18, 2024
24 tasks
@prestonvanloon prestonvanloon added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit 14d7416 Mar 25, 2024
16 of 17 checks passed
@prestonvanloon prestonvanloon deleted the spectest-report branch March 25, 2024 16:17
@saolyn saolyn mentioned this pull request Apr 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants